Use `apipkg` to provide compatibility forwarders with v1

[jaimergp]

Description

Old menuinst v1 import paths are still in use in conda.core.initialize. To avoid having to issue repodata patches for a lot of conda versions we are providing this little forwarding logic using apipkg (only on Windows).

I don't know how the team feels about adding one more dependency to the conda tree. If that's a problem we could vendor the apipkg project.

Checklist - did you ...

• [x] Add a file to the news directory (using the template) for the next release's release notes?
• [x] Add / update necessary tests?
• [ ] Add / update outdated documentation?

[jaimergp]

Ok this should be ready to go @conda/constructor. I have two main questions:

• Should we depend on apipkg or vendor it?
• apipkg has a few caveats, the main one is that once invoked, the namespace in that module is completely CLEARED. The fix is to reinject them via the attr kwarg. It works ok after that, but it was surprising behaviour. I added a comment to clarify, but I want to know if everyone is comfortable with that.

Thanks to the forwarders, menuinst v2 is backwards compatible with all the public calls I could find on Github (mostly conda.core.initialize).

[jezdez]

I don't know how the team feels about adding one more dependency to the conda tree. If that's a problem we could vendor the apipkg project.

I know that apipkg has been around for a LONG time, so it's probably pretty well tested and used, but I also remember that Holger suggested to always vendor it as it's relatively small.

[jaimergp]

I also remember that Holger suggested to always vendor it as it's relatively small.

The README suggests is a single module, but all I see is a package with several (small) modules. Am I missing something? 🤔

[jaimergp]

Ah, that's v3. Maybe I try v2, which is indeed single-module.

[jezdez]

https://github.com/pytest-dev/apipkg/commit/2acee5096f9843fda2ae608169cf5950a32f4f65 seems to have changed that, I didn't know that before

[jezdez]

@jaimergp Hmm, seeing that the v3 also added Python 3.11 support (or at least testing), I wonder if dependening might actually be better :-/ It exists both on defaults and conda-forge: https://anaconda.org/anaconda/apipkg https://anaconda.org/conda-forge/apipkg but the versions don't match.

[jaimergp]

defaults is reaaally behind with 1.5.

We can vendor the whole v3 package too. Even if they are a few files. :shrug:

[jaimergp]

WDYT about this way @jezdez?

[jezdez]

@jaimergp that's alright, I think it might be a little easier to maintain when using pip's vendoring lib, but that can be done separately

[jezdez]

(need to review the API here in depth, next week though)

[jaimergp]

Solving the conflicts dismissed the review, sorry @jezdez. Can you reapprove when you have a chance? Thanks 🙏