Rework automatic elevation logic

conda / menuinst

Cross platform menu item installation

https://conda.github.io/menuinst/

BSD 3-Clause "New" or "Revised" License

33 stars 41 forks source link

Rework automatic elevation logic #156

Closed jaimergp closed 9 months ago

jaimergp commented 10 months ago

Description

Closes #150

Checklist - did you ...

[x] Add a file to the news directory (using the template) for the next release's release notes?
[x] Add / update necessary tests?
[ ] Add / update outdated documentation?

jaimergp commented 10 months ago

Tagging @aganders3 @mrclary @marcoesters in case they are interested in a quick review, as discussed in #150 🙏

mrclary commented 10 months ago

Tagging @aganders3 @mrclary @marcoesters in case they are interested in a quick review, as discussed in #150 🙏

LGTM.

aganders3 commented 9 months ago

Tagging @aganders3 @mrclary @marcoesters in case they are interested in a quick review, as discussed in https://github.com/conda/menuinst/issues/150 🙏

I'm not quite as familiar with this code, but these changes make sense to me!

jaimergp commented 9 months ago

Thanks everyone!