Render placeholders in `menu_name`

conda / menuinst

Cross platform menu item installation

https://conda.github.io/menuinst/

BSD 3-Clause "New" or "Revised" License

33 stars 41 forks source link

Render placeholders in `menu_name` #175

Closed jaimergp closed 5 months ago

jaimergp commented 5 months ago

Description

I had forgotten to render placeholders found in the menu_name key. This fixes that behavior so folks can things like do "menu_name": "{{ DISTRIBUTION_NAME }} shortcuts" to customize the Start Menu directory.

Checklist - did you ...

[x] Add a file to the news directory (using the template) for the next release's release notes?
[x] Add / update necessary tests?
[ ] Add / update outdated documentation?

jaimergp commented 5 months ago

cc @marcoesters

jaimergp commented 5 months ago

However, I am wondering if the rendering should be happening inside _load inside api.py

All the item rendering happens in the MenuItem instance. Directory creation also happens in the Menu class. I don't see how this would be beneficial 🤔

I'll merge for now and if necessary we can open a new PR.

Thanks!