search

conda / menuinst

Cross platform menu item installation
https://conda.github.io/menuinst/
BSD 3-Clause "New" or "Revised" License
33 stars 41 forks source link

Fix commands with arguments that start with "-" #182

Closed JTignor-Raltron closed 5 months ago

JTignor-Raltron commented 5 months ago

Parameters that start with "-" are interpreted as a new argument. argparse.REMAINDER forces it to interpret all everything left in the command as a list of strings instead of new arguments. Fixes issue #177

conda-bot commented 5 months ago

We require contributors to sign our Contributor License Agreement and we don't have one on file for @JTignor-Raltron.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (https://github.com/conda/infrastructure/pull/871), and ping the bot to refresh the PR.

jaimergp commented 5 months ago

pre-commit.ci autofix

jaimergp commented 5 months ago

pre-commit.ci autofix

jaimergp commented 5 months ago

Thanks!

I added some basic tests to make sure the fix doesn't break anything else. Once you have signed the CLA, we can merge this!

JTignor-Raltron commented 5 months ago

@jaimergp Good call, I thought about that but without knowing how your testing infrastructure is set up it would have taken me significantly longer than it took you.

I did already sign the CLA, it looks like it's waiting for someone to verify that I signed so that PR can be merged?

dbast commented 5 months ago

@conda-bot check