appkit-launcher only injected when event_handler is present

conda / menuinst

Cross platform menu item installation

https://conda.github.io/menuinst/

BSD 3-Clause "New" or "Revised" License

33 stars 41 forks source link

appkit-launcher only injected when event_handler is present #183

Closed jaimergp closed 4 months ago

jaimergp commented 5 months ago

Description

Fixes https://github.com/conda/menuinst/issues/179

Some apps that their Apple events handler, so we don't need to inject our launcher. Decide by the presence of event_handler instead of CFBundle* keys.

Checklist - did you ...

[x] Add a file to the news directory (using the template) for the next release's release notes?
[x] Add / update necessary tests?
[x] Add / update outdated documentation?

mrclary commented 5 months ago

@jaimergp, tested locally and seems to be working as expected. Thanks!

jaimergp commented 4 months ago

Good, as long as we get a review from @conda/constructor we are good to merge then.