conda / menuinst

Cross platform menu item installation
https://conda.github.io/menuinst/
BSD 3-Clause "New" or "Revised" License
33 stars 41 forks source link

Fix Windows registry access mode when adding icons to file type associations #206

Closed marcoesters closed 1 month ago

marcoesters commented 1 month ago

Description

When adding an icon to a file type association in the Windows registry, the subkey is opened with read-only access. This leads to a permission error when trying to add the icon. This was not caught by tests because the data file did not have the icon key set.

Opening the subkey with KEY_SET_VALUE correctly adds the icon file.

Closes #191.

Checklist - did you ...