Closed jaimergp closed 11 hours ago
pre-commit.ci autofix
I'll give this a try locally.
It did not appear to affect anything. I can see that the registry entry is different
but the associated application is still "Python", and "Spyder (spy6b3d10)" does not appear in any application list to choose from.
Oh, I do see it in the "Details column" there in the background, next to the file size. Maybe that's what they meant with FriendlyTypeName
?
I found what VS Code uses for PY files so I'm going to give it a try now with a couple commits. I don't have a Windows VM around right now so it's going to be a blind guess. I appreciate the patience here, thanks!
With the latest push I can successfully display a "pretty name" for the executable (instead of Python). Unfortunately, looks like the icon logic is hardcoded to whatever the executable is shipping, so the only way around that is to create a forwarder shim equipped with the icon that knows how to call the actual program... a bit hacky 😬
Commit 006c579 looks much better 🎉
The "Open with" context menu still shows the Python icon but has the correct name; the "Choose another app" dialog shows the correct name and icon, and the File Explorer shows the correct icon for the file after assignment.
I think that's the best we can do for now... :/ The "Open With" icon is going to default to the EXE icon, no matter what. I'll mark this as ready so we can start the review.
Description
Hoping this fixes the issue reported at https://github.com/conda/menuinst/issues/185#issuecomment-2197286218
Checklist - did you ...
news
directory (using the template) for the next release's release notes?