search

conda / menuinst

Cross platform menu item installation
https://conda.github.io/menuinst/
BSD 3-Clause "New" or "Revised" License
38 stars 44 forks source link

Add SingleMainWindow support #265

Closed larsoner closed 2 weeks ago

larsoner commented 1 month ago

Closes #264, see description there.

Probably minor enough not to need a doc or test update? I just did git grep NoDisplay and added stuff in alphabetical order in the three places it showed up, hopefully that's good enough :crossed_fingers:

conda-bot commented 1 month ago

We require contributors to sign our Contributor License Agreement and we don't have one on file for @larsoner.

In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (https://github.com/conda/infrastructure/pull/1045), and ping the bot to refresh the PR.

larsoner commented 1 month ago

Thanks for the quick review, done @marcoesters !

marcoesters commented 1 month ago

Thanks for the quick review, done @marcoesters !

Thanks for adding the file! I will approve as soon as your CLA goes through.

jaimergp commented 2 weeks ago

@marcoesters is the CLA still unreviewed? 🤔