conda / rattler

Rust crates to work with the Conda ecosystem.
BSD 3-Clause "New" or "Revised" License
252 stars 51 forks source link

[Build Issue] reqwest-middleware 0.3.3 fails to build due to type-annotations-needed error #829

Closed iamthebot closed 2 weeks ago

iamthebot commented 4 weeks ago

Checklist

What happened?

When building locally (at least on OSX but this doen't seem platform specific?), reqwest-middleware 0.3.3 is breaking the build.

error[E0284]: type annotations needed
   --> /Users/alfredo_luque/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-middleware-0.3.3/src/client.rs:284:24
    |
284 |             self.inner.poll_ready(cx).map_err(crate::Error::Reqwest)
    |                        ^^^^^^^^^^
    |
    = note: cannot satisfy `<reqwest::Client as Service<_>>::Error == reqwest::Error`
help: try using a fully qualified path to specify the expected types
    |
284 |             <reqwest::Client as Service<Request>>::poll_ready(&mut self.inner, cx).map_err(crate::Error::Reqwest)
    |             ++++++++++++++++++++++++++++++++++++++++++++++++++++++           ~

error[E0283]: type annotations needed
   --> /Users/alfredo_luque/.cargo/registry/src/index.crates.io-6f17d22bba15001f/reqwest-middleware-0.3.3/src/client.rs:284:24
    |
284 |             self.inner.poll_ready(cx).map_err(crate::Error::Reqwest)
    |                        ^^^^^^^^^^
    |
    = note: multiple `impl`s satisfying `reqwest::Client: Service<_>` found in the `reqwest` crate:
            - impl Service<http::Request<reqwest::Body>> for reqwest::Client;
            - impl Service<reqwest::Request> for reqwest::Client;
help: try using a fully qualified path to specify the expected types

Not sure why this isn't impacting CI but curious if folks have seen this.

Additional Context

Just ran cargo build from the repo root and ensured that my toolchain matched the toolchain in rust-toolchain.

baszalmstra commented 4 weeks ago

I also just noticed this in CI. I assume some package got updated and broke our build. Ill take a closer look tomorrow.

baszalmstra commented 2 weeks ago

Since our CI has been fixed I think we can close this issue.