Fix settings, enable enterprise, and format

condemil / gist

Sublime Text plugin for creating new Gists from selected text

MIT License

725 stars 136 forks source link

Fix settings, enable enterprise, and format #174

Closed vmuriart closed 7 years ago

vmuriart commented 8 years ago

Fixes #148 #51 (Enterprise) Fixes #144 (max_gist). different approach than #171 in order to also close the enterprise issue. Incorporates pr #159, #160, Cleaned up formatting and whitespacing similar to #172 for travis test. Removed subl2 support to significantly clean-up code Removed unused(?) curl fetch.

bertrandom commented 8 years ago

I just spent 30 minutes trying to configure Gist with my work's Github Enterprise with no luck until I found this PR. @condemil, would you consider merging this in?

Saborknight commented 7 years ago

@vmuriart Could you consider adding your commit https://github.com/vmuriart/Gist/commit/73b5b97dc64ab36f41f9dcbe65d922ce8d4df85c to this to solve the AttributeError when calling Github for authors for the issue #151 to allow this feature to be re-enabled, as you stated in your commit? THANKS!

Also, accept the pull request @condemil please?

vmuriart commented 7 years ago

@Saborknight I had forgotten that this pr existed. Looking back to this, I should have broken it down into smaller pull requests to keep changes atomic. I'll add the requested commit though.

skylock commented 7 years ago

Thank you for the fix !

qkdreyer commented 7 years ago

Thanks for the fixes :)