search

condo4 / carbudget

Sailfish application to manage car cost
GNU General Public License v3.0
9 stars 15 forks source link

Create intermediate directories along with dataDir #46

Closed fferner closed 6 years ago

fferner commented 6 years ago

While testing the latest code on a fresh SailfishOS SDK (i.e. carbudget had never been installed an no other appilications had been installed in the emulator), I noticed that it wasn't possible to create a new car in carbudget. Turns out that the necessary directory was not created (and no error message to that respect). Replaced the mkdir() with mkpath() as the later will also create intermediate directories. Creating new cars on a fresh install now works.

(BTW: let me know if you prefer to have issues created for something like this before a pull request or if just a pull request is ok?)

direc85 commented 6 years ago

Yes, that is indeed a bug in my code. I have fixed it in my branch, but there is still a lot of work to do before I can make a pull request. Thanks for fixing it here!

fferner commented 6 years ago

You're welcome. It was mainly something I noticed when trying it out and seemed easy enough for me to fix. I wanted it fixed sooner so wrote the fix locally, then thought I might as well push it...