search

condo4 / carbudget

Sailfish application to manage car cost
GNU General Public License v3.0
9 stars 15 forks source link

date selection for charts pages broken #48

Open fferner opened 6 years ago

fferner commented 6 years ago

(you might know this already but as I've not seen this discussed elsewhere, I'll open this ticket).

When showing the charts for consumption, cost or oilprice the date range starts of with the first and last tanke and appears to allow the user to change the start/end date but I was not able at all to select any date in either of them. The only change I managed was setting the end date to the same as the start date.

I have had a look at the code but so far I've not been able to spot where this issue might be...

direc85 commented 6 years ago

I believe that the whole "statistics subpage" functionality is heavily in beta, as it is visible now only because I uncommented a few lines to enable them. I also believe that they should be recommented again for the next release and finished with more thought.

joonne commented 3 months ago

The app seems to crash when one selects "Consumption", "Costs" or "Fuel price" from the Statistics page. Does your comment above @direc85 mean they should be commented out? Do we have some idea what is missing from there if I'll take a look?

direc85 commented 3 months ago

I'm not sure... I guess the pickers could be replaced with simple date pickers, I think SFOS offers them. That would at least eliminate locale-based bugs. Actually, I think it's a locale/formatting bug.

Feel free to tackle the issue!

direc85 commented 3 months ago

While nudging #76 I just noticed that there's a lot of locale conversions done for dates too, so perhaps that's something you could extend in solving this? I can do the actual clean-up later, it kinda gets tedious...

joonne commented 3 months ago

Sounds good 👍