conductor-framework / conductor

[NO LONGER MAINTAINED] The Selenium framework that takes you where you want to go
Apache License 2.0
97 stars 41 forks source link

Install WebDrivers automatically #31

Open colatkinson opened 6 years ago

colatkinson commented 6 years ago

As of right now, the framework requires manual installation of platform-appropriate WebDrivers. There is a Maven plugin that handles this exact problem.

Would you consider any of the following as acceptable changes to the framework?

  1. Integrating with this plugin. As of right now, my solution to getting the two to work together involves some hacky bash scripting
  2. Loading the drivers from the resources folder. This would allow the project to work when packed into a JAR

If there are established solutions to these problems, I apologize, but I couldn't find any. I would be more than willing to work on a PR.

ddavison commented 6 years ago

I'd definitely be up for both of these. Interacting with a plugin that can automatically install these drivers would be awesome. About the bash hacking: yea i believe it. Conductor expects the drivers to be named specifically (chromdriver.mac, .linux, .exe). If we could find away to distinguish them using the plugin, that'd be awesome.

Moving the drivers to the src/test/resources directory wouldn't really be against any convention, so i have no problem with that, either!