search

conductor-sdk / conductor-csharp

The conductor-csharp repository provides the client SDKs to build task workers in C#
Apache License 2.0
41 stars 16 forks source link

Dependency injection problem #34

Closed madsph closed 1 year ago

madsph commented 1 year ago

In Conductor.Client.Extensions.DependencyInjectionExtensions.AddConductorWorker() The binding of IConductorWorkerRestClient was removed by commenting it out // services.AddTransient<IConductorWorkerRestClient, ConductorWorkerRestClient>();

But the client is needed by WorkflowTaskExecutor which is bound a few lines further down services.AddTransient<IWorkflowTaskExecutor, WorkflowTaskExecutor>();

This leads to the hosted service hanging during Start because WorkflowTaskCoordinator can't get the implementation from the serviceProvider

manan164 commented 1 year ago

Hi @madsph , Thanks for reporting this. We will push the fix in sometime.

madsph commented 1 year ago

Great thanks. Let me know if I can help with anything.