upgrade go to 1.21.0 - Githubissues

conduitio-labs / conduit-connector-redshift

Conduit connector for Amazon Redshift

Apache License 2.0

1 stars 0 forks source link

upgrade go to 1.21.0 #52

Closed AdamHaffar closed 1 month ago

AdamHaffar commented 12 months ago

Description

Upgrades Go version to 1.21.0 and updates GH actions to use go.mod instead of a hard-coded Go version.

Fixes #998

Quick checks:

[x] There is no other pull request for the same update/change.
[ ] I have written unit tests.
[x] I have made sure that the PR is of reasonable size and can be easily reviewed.

lovromazgon commented 12 months ago

Seems like the test can't reach haris-redshift-cluster-2.cricdtjk6gta.us-east-1.redshift.amazonaws.com. @hariso do you know what could be the issue?

hariso commented 11 months ago

Seems like the test can't reach haris-redshift-cluster-2.cricdtjk6gta.us-east-1.redshift.amazonaws.com. @hariso do you know what could be the issue?

The instance has been deleted, it wasn't supposed to be used in these tests. I think I added it temporarily to see if an upgrade was OK. I can do the same now as well, since I don't think it's efficient to have one running all the time.

lovromazgon commented 11 months ago

Hmm, we have an issue then with automatically merging dependabot upgrades. We rely on our tests to tell us if a dependency upgrade broke anything, so if tests are green we assume we can merge the upgrade automatically. So creating a temporary instance would help us only for this specific PR 😕

AdamHaffar commented 10 months ago

@simonl2002

lovromazgon commented 1 month ago

Closing in favor of https://github.com/conduitio-labs/conduit-connector-redshift/pull/95.