search

conduktor / conduktor-public-charts

Conduktor Helm Chart Repository
https://helm.conduktor.io
Apache License 2.0
5 stars 3 forks source link

feat(deployment): allow existing service account usage #102

Closed pchanvallon closed 2 months ago

pchanvallon commented 2 months ago

Context

Allow to use an existing service account in Deployment Kubernetes resource configuration without having to create one with this chart.

Implementation details

The parameter serviceAccount.name was already used to compute conduktor-gateway.serviceAccountName but not documented in the values list. Therefore we can always set the serviceAccountName parameter of the Deployment Kubernetes resource as it will take the default one if nothing is specified.

Related issues

Fixes #101

pchanvallon commented 2 months ago

Hello @qboileau, Thank you for your fix, looks like everything is working now.

qboileau commented 2 months ago

All good, thanks again for the contribution. Expect a new release of the Gateway chart soon.