conduktor / kafka-security-manager

Manage your Kafka ACL at scale
https://hub.docker.com/r/simplesteph/kafka-security-manager
MIT License
359 stars 159 forks source link

Liveness/readiness endpoints #108

Open eroznik opened 3 years ago

eroznik commented 3 years ago

Hello, Just wondering if this would be a good addition to the project?

Liveness could probably check that ACLs were synced successfully in the last configured sync interval. Readiness would be no-op, just return a 200.. since there is no public API(for now).

Thoughts?

simplesteph commented 3 years ago

yeah, something like a health-check point would be great

eroznik commented 3 years ago

does the described implementation make sense? i checked the code and couldn't find anything "more suitable" :thinking:

simplesteph commented 3 years ago

Sure do a PR and we can discuss

— Stephane Maarek Book a call with us https://www.conduktor.io/

--- original message --- On 7 June 2021 at 8:53 AM WEST @.*** wrote:

does the described implementation make sense? i checked the code and couldn't find anything "more suitable" 🤔

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or unsubscribe. --- end of original message ---