conedevelopment / cone-site

The new 11ty-based portfolio website of Cone.
https://conedevelopment.com
3 stars 2 forks source link

Use 4 space indentation in Front Matter #14

Closed szepeviktor closed 11 months ago

szepeviktor commented 11 months ago

From #4 Review without whitespace changes: https://github.com/conedevelopment/cone-site/pull/14/files?diff=unified&w=1 And the split view: https://github.com/conedevelopment/cone-site/pull/14/files?diff=split&w=0

Would you like a CI workflow

netlify[bot] commented 11 months ago

Deploy Preview for cone-development-site ready!

Name Link
Latest commit 1cf57e006559c78f7a0e34e23202d7d6bdcb0410
Latest deploy log https://app.netlify.com/sites/cone-development-site/deploys/64e47dfd8c7b4a0008360960
Deploy Preview https://deploy-preview-14--cone-development-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

adamlaki commented 11 months ago

image

@szepeviktor shouldn't this be 8 space?

szepeviktor commented 11 months ago

This is NOT a viktor invention! Please see the YAML Specs https://yaml.org/spec/1.2.2/#21-collections Even though GitHub and other platforms are recommending an artistic way to generate emotions.

image

szepeviktor commented 11 months ago

I cannot stop anyone from being a Artist. But I choose to be an expert without any kind of art.

❌🎨

adamlaki commented 11 months ago

Well, I kind of start to like this styleguide. How can I lint it on local?

szepeviktor commented 11 months ago

How can I lint it on local?

With the same tool as in CI: https://github.com/szepeviktor/byte-level-care/blob/3f9e004307fb0978b56cc0608588225934ecdbf1/.github/workflows/yaml.yml#L47-L50 I hope you have Python on your machine.

Here is my one size fits none config. https://github.com/szepeviktor/byte-level-care/blob/master/.yamllint.yml

adamlaki commented 11 months ago

I will look into it soon and get back to you! Thank you!

szepeviktor commented 11 months ago

Well, I kind of start to like this styleguide.

BTW I cannot get used to it! yamllint always hits me over the head.

adamlaki commented 11 months ago

Which part you can't get used to it? The structured YAML?

szepeviktor commented 11 months ago

The structured YAML?

Yes.

adamlaki commented 11 months ago

Viktor,

I could run yamllint with this package: https://www.npmjs.com/package/yaml-lint

Do I need a config file because the linted files are correct?

adamlaki commented 11 months ago

Found it, sorry: https://github.com/szepeviktor/byte-level-care/blob/master/.yamllint.yml

szepeviktor commented 11 months ago

I could run yamllint with this package: https://www.npmjs.com/package/yaml-lint

Please do not let your computer influence you!! That "yamllint" has 57 stars. https://github.com/adrienverge/yamllint has 2500 stars. I could send a blond 👱🏻‍♀️ sysadmin to install Python on your machine.

adamlaki commented 11 months ago

Yeah, you are right. I didn't get any luck with the npm package.

Python is installed (yamllint package also). Unfortunately, I can't run the command on windows (not recognized command).

adamlaki commented 11 months ago

image

It seems that python/pip is installed correctly but for some reason I couldn't find the yamllint command that is clearly listed and installed.

szepeviktor commented 11 months ago

You find this link above https://github.com/szepeviktor/byte-level-care/blob/3f9e004307fb0978b56cc0608588225934ecdbf1/.github/workflows/yaml.yml#L47-L50

python -m yamllint ./munkaink.md

adamlaki commented 11 months ago

Thank you Viktor! It works.

image

Do you have any idea for this?

adamlaki commented 11 months ago

Got it: image

szepeviktor commented 11 months ago

With yamllint you could fine-tune every single character in your YAML files 🤩

adamlaki commented 10 months ago

@szepeviktor Viktor, can you update this at the test workflow?

szepeviktor commented 10 months ago

update this

Do you mean indenting all files with 4 spaces or adding yamllint to the workflow?

adamlaki commented 10 months ago

yamllint to the workflow!

szepeviktor commented 10 months ago

Viktor is your copy-paster guy!