Fixed the dependency zserge/hid -> conejoninja/hid

conejoninja / tesoro

Go package for TREZOR devices

Other

11 stars 5 forks source link

Fixed the dependency zserge/hid -> conejoninja/hid #15

Closed xaionaro closed 6 years ago

conejoninja commented 6 years ago

I'm not sure to accept this PR, conejoninja/hid was a fork from zserge/hid with some not-so-nice changes and it's only used in android. I prefer to depend on the original repository/code than on the fork. With webUSB, it shouldn't be needed anymore to have a specific android-version.

xaionaro commented 6 years ago

ATM there are two dependencies: conejoninja/hid and zserge/hid. So you use incompatible types (while they are the same type, logically). And it is just two dependencies instead of one (so for example I have to do pull requests to both of them). However it's your call of course :)

conejoninja commented 6 years ago

Thanks, I thought I left out the android transport, but since it's in, it makes sense to only have one dependency. Updated conejoninja/hid with latest changes from zserge/hid.