search

coneoproject / COFFEE

COFFEE - A COmpiler For Fast Expression Evaluation
Other
9 stars 6 forks source link

[fix] make sure that we don'T accidentially add the finalizing ; twice #83

Closed chr-engwer closed 8 years ago

chr-engwer commented 8 years ago

I ran the test-suite locally and it passes. I guess it is safe to merge.

chr-engwer commented 8 years ago

@FabioLuporini should I just merge? Or will you do this?

FabioLuporini commented 8 years ago

I'm gonna run it too and then I'll merge it. Does it also pass the Firedrake tests?

Thanks Christian

chr-engwer commented 8 years ago

I'm gonna run it too and then I'll merge it. Does it also pass the Firedrake tests?

There was one failing test, but I discussed with others in the office and we agreed that this is not the fault of my changes, but has some other reason.

FabioLuporini commented 8 years ago

OK, thanks, merging.