search

coner-tech / coner-core

DEPRECATED A REST API for autocross event operations
GNU Affero General Public License v3.0
7 stars 3 forks source link

POST /handicapGroups #53

Closed carltonwhitehead closed 9 years ago

carltonwhitehead commented 9 years ago

add a handicap group

jshort commented 9 years ago

@carltonwhitehead thoughts on changing the REST URIs from camelcase to underscore separated? I realized I haven't worked with a REST API with camelcase URIs and I checked out twitter, dropbox, google maps, etsy and they all use underscores.

carltonwhitehead commented 9 years ago

What do we stand to gain/lose by changing to underscores vs not changing? "other people do it this way" doesn't seem like a strong justification for change. According to RFC 2616, the relevant part of the URI is case sensitive, so having them in camel case isn't going to break HTTP specs or introduce some unpredictable behavior. When we get the API spec generator up and running, it'll be clear to anyone using what the case will be.

jshort commented 9 years ago

Nothing to gain/lose other than effectively following a 'styleguide' but with respect to URI format.

jshort commented 9 years ago

@carltonwhitehead Thoughts on handicapFactor type and constraints. Right now I have it as BigDecimal and constrained between 0 and 1.

carltonwhitehead commented 9 years ago

BigDecimal from 0 to 1 seems like a good fit.