search

confessore / CoinbaseAT

The unofficial .NET/C# client library for the Coinbase Advanced Trade API
MIT License
2 stars 1 forks source link

`Method with optional parameter is hidden by overload` warning in `CoinbaseATService.cs` #2

Open astrohart opened 10 months ago

astrohart commented 10 months ago

image Figure 1. Warning about Method with optional parameter is hidden by overload.

@confessore, This is great code, and I wish it were available for .NET Framework 4.8. I am going ahead and porting over my own adaption of the code myself,

This code has to do with the two overloads of the SendServiceCall<T> method in CoinbaseATService.cs. One overload has a signature of async Task<T> SendServiceCall<T>(HttpMethod, string string) and the other overload has the signature async Task<T> SendServiceCall<T>(HttpMethod, string string, string) but the first and second overloads both have the final string parameter as optional.

This is not an optimal way to craft the code; I wish I could come up with a solution but I don't yet know the codebase well enough to fix it.

confessore commented 10 months ago

hey @astrohart ,

i crafted this library in a manic panic which lasted 72 hours. thank you for providing feedback. i need it.

i'll include this in a multi-target for netframework4+

astrohart commented 10 months ago

@confessore Thanks for the offer of help. Appreciate it.

The bind is, Coinbase recently deprecated their v2 endpoints for actually placing Buying and Selling orders, and made it a "hard" deprecation; i.e., they simply took those endpoints offline cold turkey (majorly annoying and a bad practice), forcing me to use v3 for placing orders.

Here is a link I found from the Microsoft Docs with info on how to multi-target a NuGet package: https://learn.microsoft.com/en-us/nuget/create-packages/supporting-multiple-target-frameworks

Regards,

Brian Hart