confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
47 stars 78 forks source link

e2e test provisioning code for updating kustomize files #1299

Open surajssd opened 1 year ago

surajssd commented 1 year ago

We have this code for updating kustomize file in place for e2e tests. Which IMHO is highly confusing and goes in circles a lot.

Current state

https://github.com/confidential-containers/cloud-api-adaptor/blob/452f450f704223e19d410b509c744c8c711522b9/test/provisioner/provision_azure.properties#L1-L14

https://github.com/confidential-containers/cloud-api-adaptor/blob/main/install/overlays/azure/kustomization.yaml

Proposal

Let the e2e test author define the kustomize file directly, however they want. This is the same UX as a regular user of the CAA. We don't diverge from what users do and have more flexibility in writing tests.


Similar issue: https://github.com/confidential-containers/cloud-api-adaptor/issues/1286

surajssd commented 1 year ago

Another example that proves my point is in this PR: https://github.com/confidential-containers/cloud-api-adaptor/pull/1294. If we didn't have this whole code to update kustomization.yaml file I wouldn't have to create that PR.