search

confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
47 stars 79 forks source link

libvirt: fix default IP logic #1806

Closed beraldoleal closed 5 months ago

beraldoleal commented 5 months ago

If we have a default IP address the logic that will calculate the IP based on the libvirt network will never be executed.

stevenhorsman commented 5 months ago

Does this also mean we can remove the line in the doc: https://github.com/confidential-containers/cloud-api-adaptor/blob/fd1cc099903328065aea6ebf91ea0ca6807b391e/src/cloud-api-adaptor/libvirt/README.md?plain=1#L99 that sets it and let the code figure it out itself?

beraldoleal commented 5 months ago

Does this also mean we can remove the line in the doc:

https://github.com/confidential-containers/cloud-api-adaptor/blob/fd1cc099903328065aea6ebf91ea0ca6807b391e/src/cloud-api-adaptor/libvirt/README.md?plain=1#L99 that sets it and let the code figure it out itself?

Yes, just fixed with the force-push.

beraldoleal commented 5 months ago

Hi @stevenhorsman , are the s390x errors expected?

Seems to be non related:

2024-04-26T08:19:33.7663911Z #9 35.75 checking whether the C compiler works... no
2024-04-26T08:19:33.7665167Z #9 35.76 configure: error: in `/tmp/build-libseccomp.3tZ1o/libseccomp-2.5.5':
2024-04-26T08:19:33.7667561Z #9 35.76 configure: error: C compiler cannot create executables
2024-04-26T08:19:33.7668616Z #9 35.76 See `config.log' for more details
2024-04-26T08:19:33.7669941Z #9 35.80 make: *** [Makefile.inc:138: /src/cloud-api-adaptor/podvm/staticlib/kata-libseccomp/lib/libseccomp.a] Error 77
2024-04-26T08:19:34.6013465Z #9 ERROR: process "/bin/sh -c LIBC=gnu make binaries" did not complete successfully: exit code: 2
2024-04-26T08:19:34.6119846Z ------
2024-04-26T08:19:34.6122160Z  > [podvm_builder 4/6] RUN LIBC=gnu make binaries:
2024-04-26T08:19:34.6123139Z 35.70 checking for mawk... mawk
2024-04-26T08:19:34.6124104Z 35.70 checking whether make sets $(MAKE)... yes
2024-04-26T08:19:34.6125106Z 35.71 checking whether make supports nested variables... yes
2024-04-26T08:19:34.6126775Z 35.72 checking how to create a pax tar archive... gnutar
2024-04-26T08:19:34.6127939Z 35.73 checking for s390x-gcc... s390x-linux-gnu-gcc
2024-04-26T08:19:34.6129024Z 35.75 checking whether the C compiler works... no
2024-04-26T08:19:34.6130750Z 35.76 configure: error: in `/tmp/build-libseccomp.3tZ1o/libseccomp-2.5.5':
2024-04-26T08:19:34.6131988Z 35.76 configure: error: C compiler cannot create executables
2024-04-26T08:19:34.6133172Z 35.76 See `config.log' for more details
2024-04-26T08:19:34.6134820Z 35.80 make: *** [Makefile.inc:138: /src/cloud-api-adaptor/podvm/staticlib/kata-libseccomp/lib/libseccomp.a] Error 77
2024-04-26T08:19:34.6136227Z ------
2024-04-26T08:19:34.6136816Z Dockerfile.podvm_binaries:38
2024-04-26T08:19:34.6137636Z --------------------
2024-04-26T08:19:34.6138422Z   36 |     WORKDIR /src/cloud-api-adaptor/podvm
2024-04-26T08:19:34.6139389Z   37 |     
2024-04-26T08:19:34.6140052Z   38 | >>> RUN LIBC=gnu make binaries
2024-04-26T08:19:34.6140776Z   39 |     
2024-04-26T08:19:34.6142360Z   40 |     RUN tar czvf /podvm-binaries.tar.gz -C /src/cloud-api-adaptor/podvm/files usr/ etc/
2024-04-26T08:19:34.6143525Z --------------------
2024-04-26T08:19:34.6144403Z ERROR: failed to solve: process "/bin/sh -c LIBC=gnu make binaries" did not complete successfully: exit code: 2
2024-04-26T08:19:34.6192721Z make: *** [Makefile:192: podvm-binaries] Error 1
2024-04-26T08:19:34.6208769Z ##[error]Process completed with exit code 2.

Maybe related to this?

https://github.com/confidential-containers/cloud-api-adaptor/pull/1823

stevenhorsman commented 5 months ago

@beraldoleal

Yeah, this PR was where I noticed it has got broken. Hopefully the tests in #1823 will finish soon and we can get it merged and get back working

wainersm commented 5 months ago

re-running the tests