workflows: e2e: Add the CAA image setup

confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach

Apache License 2.0

44 stars 71 forks source link

workflows: e2e: Add the CAA image setup #1828

Closed stevenhorsman closed 1 month ago

stevenhorsman commented 2 months ago

In preparation for the switch to use the latest operator we need to add code that will pass the CAA Image in to the e2e test properties file and try and work with both the new and old operator so that the workflow tests can pass pulled from main by the pull_request_target trigger
In a future PR we will remove the old kustomize versions

stevenhorsman commented 2 months ago

Unfortunately this can't actually we tested until it has merged as we use the pull_request_target trigger and I can't run it on my fork as it needs the azure runner from garm, but I've tried to make it backwards and forwards compatible and isolated it from the other changes to make it as easy to revert/update as possible if it does have issues.

wainersm commented 1 month ago

Hi @stevenhorsman !

As I said on slack I prefer this approach better to test the swap to main. I left only two small comments, overall looks good.

stevenhorsman commented 1 month ago

Hi @stevenhorsman !

As I said on slack I prefer this approach better to test the swap to main. I left only two small comments, overall looks good.

Thanks for the review. I've updated based on your changed. Obviously it's a bit tricky to test these workflow changes, but hopefully this straddles the lines between the new and old worlds so we can get both tested. It might take more than one attempt though!

wainersm commented 1 month ago

Hi @stevenhorsman ! As I said on slack I prefer this approach better to test the swap to main. I left only two small comments, overall looks good.

Thanks for the review. I've updated based on your changed. Obviously it's a bit tricky to test these workflow changes, but hopefully this straddles the lines between the new and old worlds so we can get both tested. It might take more than one attempt though!

yep, worst case nightly will be broken a few days before we manage to merge a fix. My bet is it will work though!

stevenhorsman commented 1 month ago

The nightly libvirt tests still passed after this merged (https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/9073715897), so part 1 of the success is done at least!