confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
44 stars 71 forks source link

libvirt: enable e2e test for attestation case in gha #1840

Closed huoqifeng closed 1 month ago

huoqifeng commented 1 month ago

Fixes: #1825

huoqifeng commented 1 month ago

A test is running in: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/9075730155

huoqifeng commented 1 month ago

The code looks good to me. I guess we have an issue with testing it without merging, so we might just need to merge then monitor the tests and fix/revert if there are any issues?

I'm using the branch here to test the image built from this PR https://github.com/confidential-containers/cloud-api-adaptor/blob/attestation-gha-test/.github/workflows/e2e_libvirt.yaml, I'll monitor the result before merge.

stevenhorsman commented 1 month ago

The code looks good to me. I guess we have an issue with testing it without merging, so we might just need to merge then monitor the tests and fix/revert if there are any issues?

I'm using the branch here to test the image built from this PR https://github.com/confidential-containers/cloud-api-adaptor/blob/attestation-gha-test/.github/workflows/e2e_libvirt.yaml, I'll monitor the result before merge.

Nice - I didn't realise that we had a workload dispatch trigger on the job to pick the branch.

huoqifeng commented 1 month ago

The job failed, I downloaded this podvm image from the OCI image ghcr.io/confidential-containers/podvm-generic-ubuntu-amd64:ci-pr1840 and tried locally, got error like below.

May 14 10:15:58 podvm-busybox-dd5d43ba kata-agent[847]: [2024-05-14T10:15:58Z ERROR attestation_agent::rpc::getresource::ttrpc] Call AA-KBC to get resource failed: AA does not support the given KBC module! Module: cc_kbc
May 14 10:16:00 podvm-busybox-dd5d43ba kata-agent[847]: [2024-05-14T10:16:00Z ERROR attestation_agent::rpc::getresource::ttrpc] Call AA-KBC to get resource failed: AA does not support the given KBC module! Module: cc_kbc

So, something wrong when build the kata-agent and binaries when build podvm image in this PR, will check it...

huoqifeng commented 1 month ago

Test passed here https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/9088192913/job/24977332605 which is: