search

confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
44 stars 71 forks source link

Bug: fix the aa-kbc-params error in fedora #1853

Open huoqifeng opened 3 weeks ago

huoqifeng commented 3 weeks ago

Fixes: #1852

huoqifeng commented 3 weeks ago

@mkulke @bpradipt not sure whether it's reasonable for azure and aws provider, may you please check?

huoqifeng commented 3 weeks ago

The problem is on fedora, the failure in ExecStartPre in process-user-data blocks ExecStart for libvirt provider. I broken it into 2 services. process-user-data-provision and process-user-data-update while process-user-data-update depends on cloud-final.service because libvirt and other providers like ibmcloud uses cloud-init to provision user-data.

bpradipt commented 3 weeks ago

@huoqifeng how was the libvirt provider working all this while with the packer created image?

huoqifeng commented 3 weeks ago

@huoqifeng how was the libvirt provider working all this while with the packer created image?

I'm not 100% sure, but I guess ExecStartPre failure won't cause ExecStart skipping on ubuntu. Another thing I'm digging is why after the service change I made in this PR. the file /etc/agent-config.toml changed but not /run/peerpod/agent-config.toml without the main.go change. -- It worked on ubuntu image. @bpradipt

huoqifeng commented 2 weeks ago

I guess this has been fixed by PR https://github.com/confidential-containers/cloud-api-adaptor/pull/1858 @mkulke

mkulke commented 2 weeks ago

I guess this has been fixed by PR #1858 @mkulke

I wouldn't expect this (at least intentionally). the above PR should not change behaviour in this regard.