Marking CI jobs required

[wainersm]

This topic was raised by me on Oct 9, 2024 Peer Pods Interlock meeting: all CI jobs for pull requests are currently non-required. I suggested to make some of them required, so to avoid situation where regressions sneaked in by mistake and it can take time until one realizes and effectively fix it. Some jobs are quality-code related, for example the Go linters, and we don't want the code "degradation" over time. So on the meeting no ones was opposed to the suggestion, now the question is what jobs should be required.

As of today, the list is:

Job	should be required? (y/n)	Comments
Commit Message Check / Commit Message Check
build / cloud-api-adaptor (dev, ubuntu-latest)
check links / checklinks
e2e tests
build / cloud-api-adaptor (release, ubuntu-latest)
build / controllers (peerpod-ctrl) (pull_request)
lint / golangci-lint
build / volume controllers (csi-wrapper)
lint / shellcheck
build / webhook
lint / go mod tidy
lint / govulncheck
lint / Packer check
lint / Terraform check
DCO
License Compliance
Security Analysis

PLEASE LEAVE YOUR COMMENTS THAT I WILL UPDATE THE TABLE ABOVE

[wainersm]

IMO we should make required:

• Commit Message Check
• all build / *
• all lint / *
• DCO

The e2e tests shouldn't be required because we still want to run with discretion (I guess).

Technically Security Analysis is very important but I don't know exactly whether it makes useful analysis to our project. Also don't know if the job is stable. Kind of the same for License Compliance

[stevenhorsman]

I think I'd start with all apart from the FOSSA scans (as I don't understand enough about them yet) and e2e tests. Some of these e.g. webhook & caa build are occasionally flakely, but this might prompt us to fix them up