search

confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
48 stars 88 forks source link

SecureComms: Add testing facility for e2e tests #2124

Closed davidhadas closed 1 week ago

davidhadas commented 1 month ago

Modify the .github/workflow files to enable adding e2e tests for secure comms. The added code is generalized to enable controlling the libvirt e2e testing matrix using a json file

davidhadas commented 1 month ago

This PR is expected to fail when using the existing workflow and succeed when using the modified workflow.

It fails now since the existing workflow calls config_libvirt.sh without a parameter The config_libvirt.sh without a parameter returns the list of e2e tests instead of actually installing libvirt et al. This results in make e2e_tests failure later on (since libvirt and other packages were not installed).

As an alternative we could create a new script (e.g. config_libvirt_matrix.sh) that will return the list of matrix options. Then, as part of the new workflow, we can call this script instead of calling config_libvirt.sh without parameters.
The only benefit that I see from this is to allow the existing workflow to pass the e2e tests of this PR. (I am not sure this justifies introducing another script)