search

confidential-containers / cloud-api-adaptor

Ability to create Kata pods using cloud provider APIs aka the peer-pods approach
Apache License 2.0
48 stars 88 forks source link

workflow: Add actionlint workflows #2146

Closed stevenhorsman closed 1 week ago

stevenhorsman commented 1 week ago

On PRs that update anything in the workflows directory, add an actionlint run to validate our workflow files for errors and hopefully catch issues earlier.

Also fix the many issues we already have!

stevenhorsman commented 1 week ago

The run against my fork can be seen: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11744726638/job/32720502155, but I was hoping that the workflow would be run on this PR as well, so I'm not sure if I've made a mistake with it?

wainersm commented 1 week ago

Hi @stevenhorsman !

The run against my fork can be seen: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11744726638/job/32720502155, but I was hoping that the workflow would be run on this PR as well, so I'm not sure if I've made a mistake with it?

There is a typo on the paths filter: s/worksflows/workflows/ So it's expecting changes on wrong path. In your fork you probably triggered manually (workflow_dispatch).

stevenhorsman commented 1 week ago

Hi @stevenhorsman !

The run against my fork can be seen: https://github.com/stevenhorsman/cloud-api-adaptor/actions/runs/11744726638/job/32720502155, but I was hoping that the workflow would be run on this PR as well, so I'm not sure if I've made a mistake with it?

There is a typo on the paths filter: s/worksflows/workflows/ So it's expecting changes on wrong path. In your fork you probably triggered manually (workflow_dispatch).

Awesome - thanks for the spot I knew there was something wrong - and I did do the workflow_dispatch in my fork!

stevenhorsman commented 1 week ago

It's running now here: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/11819549958/job/32929721287?pr=2146. Big thank you to @wainersm!