search

confidential-containers / documentation

Documentation for the confidential containers project
Apache License 2.0
73 stars 48 forks source link

Use the correct deployment manifest for the operator #42

Closed bpradipt closed 1 year ago

bpradipt commented 2 years ago

Signed-off-by: Pradipta Banerjee pradipta.banerjee@gmail.com

dcmiddle commented 2 years ago

This looks like this changes the directions in main to reference the deploy.yaml in the ccv0-branch. Is that intended?

bpradipt commented 2 years ago

This looks like this changes the directions in main to reference the deploy.yaml in the ccv0-branch. Is that intended?

@dcmiddle yes, this is intentional to ensure the existing ssh-demo works for folks following the given instructions. The code in main has deviated significantly and the existing ssh-demo will not work when using main.

mythi commented 2 years ago

This looks like this changes the directions in main to reference the deploy.yaml in the ccv0-branch. Is that intended?

@dcmiddle yes, this is intentional to ensure the existing ssh-demo works for folks following the given instructions. The code in main has deviated significantly and the existing ssh-demo will not work when using main.

I'd suggest to add this to the commit message.

sameo commented 1 year ago

@bpradipt Could you please amend the commit message so we can merge that PR, please?

bpradipt commented 1 year ago

@bpradipt Could you please amend the commit message so we can merge that PR, please?

@sameo I have updated the commit message.

dcmiddle commented 1 year ago

I don't oppose this being merged, but just for clarity, when would we switch the directions in main back to main xor why would we not point demo users to the directions in the ccv0 branch.

bpradipt commented 1 year ago

I don't oppose this being merged, but just for clarity, when would we switch the directions in main back to main xor why would we not point demo users to the directions in the ccv0 branch.

We do not have an equivalent ssh-demo for the latest code yet. Once that is ready, we should add it to the operator-demo folder.