confidential-containers / guest-components

Confidential Containers Guest Tools and Components
Apache License 2.0
81 stars 89 forks source link

AA: add GetTeeType API #613

Closed Xynnn007 closed 2 months ago

Xynnn007 commented 2 months ago

This new API is used for a caller to get current platform name.

---New things added

In some scenarios, callers want to get the name of current platform. Thus we need this basic semantics for AA.

Xynnn007 commented 2 months ago

Rebased and ready for review. cc also @imlk0

imlk0 commented 2 months ago

Rebased and ready for review. cc also @imlk0

Thanks @Xynnn007. That solves my problem.

mythi commented 2 months ago

In some scenarios, callers want to get the name of current platform.

I think it would be good to clarify in the commit message what are the scenarios and who are the callers.

Xynnn007 commented 2 months ago

I think it would be good to clarify in the commit message what are the scenarios and who are the callers.

Yes. Added the details. AA can run outside CoCo scenarios. For example, AA would run on an IaaS platform, and a user of such IaaS platform could get the tee type. Another example is some PaaS services on top of such IaaS platform, they also want to know the platform name.

mythi commented 2 months ago

AA would run on an IaaS platform, and a user of such IaaS platform could get the tee type.

I was suspecting it might be something like this. It makes me think if it overlaps with what node-feature-discovery already gives.

Xynnn007 commented 2 months ago

AA would run on an IaaS platform, and a user of such IaaS platform could get the tee type.

I was suspecting it might be something like this. It makes me think if it overlaps with what node-feature-discovery already gives.

Yes. As a confidential runtime component, AA should have such ability itself.