search

confidential-containers / guest-components

Confidential Containers Guest Tools and Components
Apache License 2.0
81 stars 89 forks source link

ci: Remove duplicate build when a PR is merged to main #644

Closed arronwy closed 2 months ago

arronwy commented 2 months ago

Make CI only build when there is a PR, or a direct push to main.

BbolroC commented 2 months ago

Hmm.. it seems the redundant checks are still scheduled to run, and some of the checks where s390x is involved are gone in https://github.com/confidential-containers/guest-components/pull/647, which has rebased on main after this merge. (Sorry, it makes sense because it only updates workflow files) I think something is going wrong here.

Update: I do not have any CI jobs of interest triggered when #647 is merged. I think what happened after this merge is something where a workflow on main (not updated by this PR) was triggered. So I would say, we don't have any issues. Thanks for your patience.

No, we have an issue on the conditional if: github.event_name != 'push' || github.event.pull_request.merged == false. I will look into it and raise a PR. Thanks.

BbolroC commented 2 months ago

The CI is behaving as this PR intended. Thanks.