search

confidential-containers / guest-components

Confidential Containers Guest Tools and Components
Apache License 2.0
83 stars 95 forks source link

GHA: Fix condition for duplicate checks post-merge #648

Closed BbolroC closed 3 months ago

BbolroC commented 3 months ago

Despite #644, duplicate checks are still being triggered post-merge. The following condition seemed intuitive:

But it turns out that pull_request.merged is still false on merge, which allows the job to proceed. (see https://github.com/BbolroC/cc-guest-components/actions/runs/10215060610/workflow)

This commit focuses solely on github.event_name != 'push', which is true on merge. (see https://github.com/BbolroC/cc-guest-components/actions/runs/10215137827/workflow)

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

BbolroC commented 3 months ago

Let’s see if anyone opposes this after the intended CI behavior occurs. Thanks! (maybe someone who wants to push something directly to main?)