search

confidential-containers / guest-components

Confidential Containers Guest Tools and Components
Apache License 2.0
81 stars 89 forks source link

Fix configuration file default value and make error information more detailed #726

Closed Xynnn007 closed 5 days ago

Xynnn007 commented 6 days ago

Please see the commit message of this PR.

cc @stevenhorsman

mythi commented 5 days ago

This default value of KBS cert would make the KBS client to read it as a PEM cert, thus always fails to launch.

The unit tests probably need updating to get this path covered?

Xynnn007 commented 5 days ago

at the moment users have to specify explicitly, even if a user does not use the feature.

credentials = []

Without this section it could be fine. See the unit test for config example https://github.com/confidential-containers/guest-components/blob/main/confidential-data-hub/hub/src/config.rs#L249-L261

The unit tests probably need updating to get this path covered?

Updated. See https://github.com/confidential-containers/guest-components/pull/726/files#diff-51b4317c4f4b87e6825be8fe3761800028d718fff2c48542e78904a6fc82aba1R303