confidential-containers / guest-components

Confidential Containers Guest Tools and Components
Apache License 2.0
83 stars 95 forks source link

tdx-attester: log error on empty TSM report #825

Open mythi opened 21 hours ago

mythi commented 21 hours ago

Fixes: #823

tdx_guest TSM provider covers a wide range of errors which trigger an errno on outblob read but can also return empty reports without error.

One such scenario seems to be when Qemu isn't connecting to TDX QGS properly (likely due to misconfiguration) but returns back with an empty buffer.

Notify users about this scenario and log an error on empty TSM report but don't turn it into a new error because there isn't any.

Note: when used with evidence_getter, a logger must be enabled to get the logs visible.

Xynnn007 commented 9 hours ago

~Let me handle the CI failure which is not related to this PR.~

~Updated: See #826~

Updated 2nd: please take a rebase. Now the CI is fixed.