search

confidential-containers / operator

Operator to deploy confidential containers runtime
Apache License 2.0
113 stars 60 forks source link

Use consistent yaml file extension #344

Closed portersrc closed 9 months ago

GabyCT commented 9 months ago

lgtm

portersrc commented 9 months ago

LGTM. Normally convention is that we start our commit headers with the components/area being updated e.g. ci: ..., or workflows: ..., but it's not mandatory and enforced, so doesn't block merging.

I'll start doing this, then. "Components/area" seems to be a loose term based on what I've seen people doing, but best effort is still an improvement.

portersrc commented 9 months ago

lgtm although you might have also included the tests/e2e/ansible/*.yml files as well ;-)

Hey say less

wainersm commented 9 months ago

Thanks @portersrc ! Now we just sit and wait someone send a PR to switch back to .yml ;)

portersrc commented 9 months ago

Now we just sit and wait someone send a PR to switch back to .yml ;)

Yes lol; I'd be fine with that as long as it's consistent.

the README.md containes 2 more references

Thank you! That was sloppy of me.

As for the kube-flannel.yml, I think it would be better to include it as well

OK, giving it a shot.

ldoktor commented 9 months ago

still looks good, I can see 2 previous acks so let me get this in ;-)