tests: Improve variable definition in tests/e2e scripts

confidential-containers / operator

Operator to deploy confidential containers runtime

Apache License 2.0

102 stars 56 forks source link

tests: Improve variable definition in tests/e2e scripts #346

Closed GabyCT closed 4 months ago

GabyCT commented 5 months ago

To have a better consistency across the test/e2e scripts this PR improves the variable definition by using local as a best practice.

GabyCT commented 5 months ago

@ldoktor let me do it

GabyCT commented 4 months ago

@ldoktor @wainersm changes applied

ldoktor commented 4 months ago

Looks good although I spotted a few variables in operator.sh in wait_for_stabilization function, could you please include them as well? (that should be all, I hope :-D)

GabyCT commented 4 months ago

@ldoktor thanks for the feedback, sorry that I missed those

GabyCT commented 4 months ago

Thank you for bearing with my nitpicks :-)

not worries, thanks for the feedback helps me to improve my work