search

confidential-containers / operator

Operator to deploy confidential containers runtime
Apache License 2.0
113 stars 60 forks source link

pre-install: General fixes in pre-install scripts #351

Closed GabyCT closed 7 months ago

GabyCT commented 9 months ago

This PR adds general fixes in the pre-install scripts like removing tab spaces where they are not needed as well as improving the definition of the variables.

GabyCT commented 8 months ago

Thanks @GabyCT, this improves the situation somehow. There is still a room for improvement, though. If you had some time I'd recommended using shellcheck to check the files (not saying it must pass with not failures, but it should help identifying the most obvious ones).

Still as I mentioned, it's definitely better than before so it can be merged as is and perhaps in the future someone can continue.

PS: I'm a big fan of yours style fixes, thank you for them :-)

@ldoktor thanks for all the feedback, I just use it the shellchek tool thanks

GabyCT commented 8 months ago

@ldoktor changes applied thanks

GabyCT commented 8 months ago

@ldoktor thanks for all the feedback, I really appreciate it changes applied