search

confidential-containers / operator

Operator to deploy confidential containers runtime
Apache License 2.0
113 stars 60 forks source link

tests/e2e: Jenkins to GHA migration for SEV and SNP #352

Closed AdithyaKrishnan closed 4 months ago

AdithyaKrishnan commented 8 months ago

The ccruntime-pr.yaml file has been modified and works only for amd specific tests currently. Work adds on to operator pull 295

AdithyaKrishnan commented 8 months ago

@portersrc @fitzthum DCO passing finally.

fitzthum commented 8 months ago

Ok, higher level question here. Maybe @wainersm will have some good advice.

Do you think we should have a separate workflow for SEV? I'm not sure if this is going to scale very well as we introduce more tests. Can we instead modify the existing e2e workflow to add SEV/SNP support?

ldoktor commented 8 months ago

Ok, higher level question here. Maybe @wainersm will have some good advice.

Do you think we should have a separate workflow for SEV? I'm not sure if this is going to scale very well as we introduce more tests. Can we instead modify the existing e2e workflow to add SEV/SNP support?

Well the workflow should be similar, shouldn't it? Only the set of tests and perhaps some setup parts will differ and that should be part of the scripts but IMO the workflows should be shared as much as possible.

wainersm commented 8 months ago

Ok, higher level question here. Maybe @wainersm will have some good advice. Do you think we should have a separate workflow for SEV? I'm not sure if this is going to scale very well as we introduce more tests. Can we instead modify the existing e2e workflow to add SEV/SNP support?

Well the workflow should be similar, shouldn't it? Only the set of tests and perhaps some setup parts will differ and that should be part of the scripts but IMO the workflows should be shared as much as possible.

Yes, that's how I see it as well.

stevenhorsman commented 5 months ago

See https://github.com/confidential-containers/operator/pull/383/files for an example