search

confidential-containers / operator

Operator to deploy confidential containers runtime
Apache License 2.0
113 stars 60 forks source link

enclave-cc e2e updates #353

Closed mythi closed 7 months ago

mythi commented 8 months ago

Hello Mikko, this does fixes the problem. Since on that would you consider adding some debug info when such issue happens (like kubectl describe pod/enclave-cc-pod-sim) to the workflow?

Good point, I can look into adding something there.

Also this is the first time I tried running this locally, is there a suggested way of doing that? I used a kcli vm with kind installed, then I ran tests/e2e/operator.sh to create the registry (and populate it), then I created the kind cluster, modified it's /etc/hosts to point registry to main route and then I was able to run the test successfully. Not really straight forward so I guess there ought to be a better way.

I don't have any good script. A kcli vm with kind installed is a good starting point since it's roughly what a Github runner is. All the steps after that are in https://github.com/confidential-containers/operator/blob/016a7d4d2e7da783eec299a4f9ac5f25f140feed/.github/workflows/enclave-cc-e2e.yaml#L35-L70 and it should be possible to just copy-and-paste there. The tests I'm fixing here are not using tests/e2e/operator.sh

ldoktor commented 8 months ago

Hello Mikko, this does fixes the problem. Since on that would you consider adding some debug info when such issue happens (like kubectl describe pod/enclave-cc-pod-sim) to the workflow?

Good point, I can look into adding something there.

Thanks, could be a separate PR to not to block this fix, though

Also this is the first time I tried running this locally, is there a suggested way of doing that? I used a kcli vm with kind installed, then I ran tests/e2e/operator.sh to create the registry (and populate it), then I created the kind cluster, modified it's /etc/hosts to point registry to main route and then I was able to run the test successfully. Not really straight forward so I guess there ought to be a better way.

I don't have any good script. A kcli vm with kind installed is a good starting point since it's roughly what a Github runner is. All the steps after that are in

https://github.com/confidential-containers/operator/blob/016a7d4d2e7da783eec299a4f9ac5f25f140feed/.github/workflows/enclave-cc-e2e.yaml#L35-L70 and it should be possible to just copy-and-paste there.

Sure, that's what I followed, propagating the docker registry was the only troublemaker... Still would be nice to have a simple way to reproduce things locally...

The tests I'm fixing here are not using tests/e2e/operator.sh

I know, but it can serve well to setup the registry :-).