confidential-containers / simple-kbs

Key Broker Server for SEV(-ES)
Apache License 2.0
10 stars 12 forks source link

Fixes tools/run_local_tests.sh by updating path for SIMPLE_KBS_DIR #51

Closed dunnderr closed 1 year ago

dunnderr commented 1 year ago

Fixes tools/run_local_tests.sh by updating path for SIMPLE_KBS_DIR from $(dirname $0)/.. to $(dirname $0)../db. This ensures that run_local_tests.sh will run after moving database sql definitions to db directory in repository.

Signed-off-by: Derren Dunn dunnderr@us.ibm.com

fitzthum commented 1 year ago

This PR has no changes in it. Did Dov's PR make the same updates?

dubek commented 1 year ago

This PR has no changes in it. Did Dov's PR make the same updates?

Yes, indeed, #52 included this change (I had to have a working script to test sqlite).

We can either:

  1. close this PR
  2. use the chance and rename the SIMPLE_KBS_DIR variable (according the comment above).
dunnderr commented 1 year ago

I am ok with closing this PR since #52 already included it.

fitzthum commented 1 year ago

Ok. Sorry I didn't notice that when we were merging #52.