remove hardcoded MAX_WORKING_AP_COUNT

confidential-containers / td-shim

Confidential Containers Shim Firmware

Other

97 stars 53 forks source link

remove hardcoded MAX_WORKING_AP_COUNT #705

Closed jyao1 closed 5 months ago

jyao1 commented 5 months ago

https://github.com/confidential-containers/td-shim/blob/main/td-shim/src/bin/td-shim/td/tdx_mailbox.rs#L19

What happen if VMM injects more CPUs than MAX_WORKING_AP_COUNT ?

gaojiaqi7 commented 5 months ago

This sets a maximum number of APs that are used to accept memory and is intentional. If VMM injects more CPUs than MAX_WORKING_AP_COUNT, only MAX_WORKING_AP_COUNT CPUs will be waked up to do the works they are assigned.

jyao1 commented 5 months ago

If there is no impact to the OS ACPI table, then it is OK.