confidential-containers / trustee

Attestation and Secret Delivery Components
Apache License 2.0
59 stars 81 forks source link

use standard data formats? #3

Closed thomas-fossati closed 1 year ago

thomas-fossati commented 2 years ago

Three potential places where you could use existing standard formats instead of defining new ones:

One advantage is that there are tons of library code that can be readily used to pull together the service.

Another advantage is that a standard is usually the result of years of collective engineering experience, and tend to absorb already a lot of the "hard learned lessons" :-)

sameo commented 2 years ago

Makes a lot of sense @thomas-fossati , thanks for the advices. During the next week or so I'll update the docs accordingly and will add you as a reviewer if you're ok with that.

thomas-fossati commented 2 years ago

During the next week or so I'll update the docs accordingly and will add you as a reviewer if you're ok with that.

Sure, thanks!

sameo commented 2 years ago

@thomas-fossati Finally had a stab at it. Assuming JWE makes more sense for the Response payload than JWS, I tried to move to those 3 standards. Whenever you have time, you can have a look at: https://github.com/confidential-containers/kbs/pull/9

ariel-adam commented 1 year ago

@thomas-fossati is this issue still relevant or can be closed? If it's still relevant to what release do you think we should map it to (mid-November, end-December, mid-February etc...)?

thomas-fossati commented 1 year ago

@thomas-fossati is this issue still relevant or can be closed?

Please close it. And thank you very much for addressing my comments in such a quick, open and effective way.

ariel-adam commented 1 year ago

Cool, closing the issue

jialez0 commented 1 year ago

@sameo I think we can close this issue now.