confidential-containers / trustee

Attestation and Secret Delivery Components
Apache License 2.0
61 stars 81 forks source link

kbs-client: encode policies with nopad-url-b64 #400

Closed mkulke closed 4 months ago

mkulke commented 4 months ago

The underlying kbs code expects a string in a specific b64 encoding. The client will fail to set certain policies if standard b64 encoding is used.

Not sure what the reasoning behind the b64 encoding of a policy body is, but it is very deep into the call graph in the the policy engines' implementation, so it's reasonable to change it at the client, I think.

mkulke commented 4 months ago

we are facing the bombs deployed before

😅, it's been confusing to debug why some policies would fail, but it should soon be covered by some tests hopefully, as I stumbled over this while refining some tests. It's probably a good idea to verify such input expectations earlier on the api level.