search

confidential-containers / trustee

Attestation and Secret Delivery Components
Apache License 2.0
51 stars 77 forks source link

KBS: refactor code structure #430

Closed Xynnn007 closed 2 days ago

Xynnn007 commented 1 week ago

This commit will tidy the code under kbs directory. It deletes api-server crate, and move all logic of api-server to KBS crate, also mark kbs as a binary of the crate.

This commit also makes some common dependencies of sub-crates to use the same version of workspace.

Let's mark this PR draft until the release and other PRs, or it will cause a bunch of rebases.

Xynnn007 commented 1 week ago

I think this is a big improvement. A few comments.

One high-level thing is that I wonder if we want to have kbs/kbs and attestation-service/attestation-service dirs. It seems like we could move Cargo.toml and build.rs up a dir and get rid of the second kbs/as directory. wdyt?

Nice idea. how about the following tree like Updated currently

.
├── attestation-service
├── kbs
├── rvps
├── deps
│   └── verifier
└── tools
    └── kbs-client