confidential-containers / trustee

Attestation and Secret Delivery Components
Apache License 2.0
67 stars 88 forks source link

gha: Add image build check for s390x #576

Closed BbolroC closed 4 days ago

BbolroC commented 5 days ago

Issue #568 highlights the need for an image build check for s390x, similar to what we have for x86_64. This PR addresses the need by:

Notable change:

The changes on PR events have been verified with:

The changes on merge needs to be verified after merging this PR. I will keep an eye on how it goes and bring things up immediately when something goes wrong. Thanks.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

BbolroC commented 4 days ago

It seems that two workflows (e.g., one triggered on merge and another on PR events) are being executed when the PR is merged. This results in a duplicate image build step, similar to what we observed in the guest-components repository.

I will create a follow-up PR similar to the following to deduplicate the image build process:

Thanks.


This behaviour is not something this PR has introduced. The docker build check workflow has been called on merge together with the build-and-push workflow like: https://github.com/confidential-containers/trustee/actions/runs/11854184038/job/33035819254