search

config-i1 / smooth

The set of functions used for time series analysis and in forecasting.
89 stars 19 forks source link

minor test failure #205

Closed bastistician closed 1 year ago

bastistician commented 1 year ago

Checking the current CRAN version 3.2.1, this test

https://github.com/config-i1/smooth/blob/d65e2f7d5430717185ce561cac275bb46c30a61b/tests/testthat/test_es.R#L10

fails on Alpine Linux, possibly due to a lack of numerical tolerance:

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test_es.R:10:5'): Test damped-trend ETS on BJsales ────────────────
  round(es(BJsales, model = "AAdN", silent = TRUE)$phi, 2) not equal to 0.86.
  1/1 mismatches
  [1] 0.85 - 0.86 == -0.01

  [ FAIL 1 | WARN 0 | SKIP 74 | PASS 33 ]
config-i1 commented 1 year ago

Thanks! Yes, this is because of the tolerance. I'll fix it.

config-i1 commented 1 year ago

Should be fixed now in 468949b1f4f4a72cc638c352242a3c4ae4d07375