search

config-i1 / smooth

The set of functions used for time series analysis and in forecasting.
89 stars 20 forks source link

fix usage of 'traditional' instead of 'usual' for function adam #220

Closed MonikaZimmermann closed 5 months ago

MonikaZimmermann commented 5 months ago

While examining the code for the adam function in adam.R, I discovered that it is implemented with the parameter 'bounds=c("usual","admissible","none")'. However, in the documentation for the bounds parameter '@param bounds', bounds are described as '...traditional - restricting the values within (0, 1)...'.

In the 'adamGeneral.R' file, bounds are implemented as 'bounds=c("traditional","usual","admissible","none")'. However, when bounds="traditional", line 2483 'bounds <- match.arg(bounds,c("usual","admissible","none"))' throws an error.

Additionally, while reviewing the examples in 'adam.Rmd', 'traditional' was used once more, where 'usual' would provide better clarity.

config-i1 commented 5 months ago

Thanks for spotting that! I think I left it half way through, forgetting to implement the options properly (there are several: https://openforecast.org/adam/ETSParametersBounds.html - only two are supported by ADAM).

MonikaZimmermann commented 5 months ago

You are welcome! Thank you for providing the link to your book. I worked with it a lot in the past months and really like the intuitive explanations!