Additional minor improvements

adams85 commented 1 year ago

Describe the purpose of your pull request

Improves error reporting when setting type and default value type mismatch. Firstly, makes GetValue<T>, GetValueDetails<T>, etc. methods fail early if the specified CLR type is not supported. Secondly, provides a meaningful error message when the specified CLR type and the setting type mismatch.
Improves ConfigDeserializer performance by using HTTP ETag for change detection instead of calculating a hash.
Improves SHA1 hashing implementation by changing the logic so it doesn't new up an SHA1 instance on each hash calculation (as this could be fairly expensive).
Eliminates ModuleInitalizer trick used in tests as I've learned it's unnecessary because MSTest provides that feature out of the box.

Requirement checklist (only if applicable)

[x] I have covered the applied changes with automated tests.
[x] I have executed the full automated test set against my changes.
[x] I have validated my changes against all supported platform versions.
[x] I have read and accepted the contribution agreement.

adams85 commented 1 year ago

Looks like Sonar doesn't like SHA1 :( How to make it understand that it's safe in this case?

z4kn4fein commented 1 year ago

Looks like Sonar doesn't like SHA1 :( How to make it understand that it's safe in this case?

Did it for ya!

adams85 commented 1 year ago

You're the man! Thanks 👍

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

86.2% Coverage
0.0% Duplication

sigewuzhere commented 1 year ago

Please point me to the right direction. Where did the UX change? Which files should I focus on?

adams85 commented 1 year ago

Only the first commit is relevant from the UX standpoint. First of all, there's a Trello ticket about improving the error message when the type of the default value and the type of the actual value mismatch. This is done here. On top of that, I also improved the logic of the GetValueXXX methods to fail early if the default value type is not supported. This also aligns the behavior with other SDKs like the Swift one.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!